Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

[ira.weiny]

On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote:
> On 4/13/2015 8:22 AM, Michael Wang wrote:
> > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> > index 65994a1..d54f91e 100644
> > --- a/include/rdma/ib_verbs.h
> > +++ b/include/rdma/ib_verbs.h
> > @@ -75,10 +75,13 @@ enum rdma_node_type {
> >  };
> >  
> >  enum rdma_transport_type {
> > +	/* legacy for users */
> >  	RDMA_TRANSPORT_IB,
> >  	RDMA_TRANSPORT_IWARP,
> >  	RDMA_TRANSPORT_USNIC,
> > -	RDMA_TRANSPORT_USNIC_UDP
> > +	RDMA_TRANSPORT_USNIC_UDP,
> > +	/* new transport */
> > +	RDMA_TRANSPORT_IBOE,
> >  };
> >  
> >  __attribute_const__ enum rdma_transport_type
> > @@ -1501,6 +1504,8 @@ struct ib_device {
> >  	int		           (*query_port)(struct ib_device *device,
> >  						 u8 port_num,
> >  						 struct ib_port_attr *port_attr);
> > +	enum rdma_transport_type   (*query_transport)(struct ib_device *device,
> > +						      u8 port_num);
> >  	enum rdma_link_layer	   (*get_link_layer)(struct ib_device *device,
> >  						     u8 port_num);
> >  	int		           (*query_gid)(struct ib_device *device,
> 
> libibverbs also exposes transport at the device level. Isn't a change to
> make transport per port rather than per device needed there as well to
> be consistent with these proposed kernel changes ? If so, would the
> additional IBoE transport be exposed ? We also need to worry about
> backward compatibility for existing applications.

Early on in this thread we agreed that user space would stay the same until we
get the kernel straightened out.  The above enum and function are not exported
to user space so I believe this is in alignment with that plan.

Ira

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/