Re: [patch for 4.0] x86: silence warning in /dev/mem support

[Ingo Molnar]

* Pavel Machek <pavel@xxxxxx> wrote:

> The compiler is right, the code is tricky, but it is also correct
> AFAICT.
> 
> Signed-off-by: Pavel Machek <pavel@xxxxxx>
> 
> diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
> index fdf617c..8a8dce8 100644
> --- a/arch/x86/mm/ioremap.c
> +++ b/arch/x86/mm/ioremap.c
> @@ -341,7 +341,7 @@ void *xlate_dev_mem_ptr(phys_addr_t phys)
>  
>  	addr = (void __force *)ioremap_cache(start, PAGE_SIZE);
>  	if (addr)
> -		addr = (void *)((unsigned long)addr | (phys & ~PAGE_MASK));
> +		addr = (void *)((unsigned long)addr | (unsigned long) (phys & ~PAGE_MASK));

What warning did it generate and which compiler version?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/