RE: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm
From: Hefty, Sean
Date: Thu Apr 16 2015 - 10:31:47 EST
> > This is equivalent to today where the checks are per node rather than
> > per port.
> >
> > Should all checks here be port 1 based or only certain ones like listen
> > ? For example, in connect/reject/disconnect, don't we already have port
> > ? Guess this can be dealt with later as this is not a regression from
> > the current implementation.
>
> Yeah, these parts of cma may need more carve in future, like some new
> callback
> for different CM type as Sean suggested.
>
> Maybe directly using 1 could help to highlight the problem ;-)
Only a few checks need to be per device. I think I pointed those out previously. Testing should show anywhere that we miss fairly quickly, since port would still be 0. For the checks that can be updated to be per port, I would rather go ahead and convert them.
- Sean
N§²æ¸yú²X¬¶ÇvØ)Þ{.nÇ·¥{±êX§¶¡Ü}©²ÆzÚj:+v¨¾«êZ+Êzf£¢·h§~Ûÿû®w¥¢¸?¨è&¢)ßfùy§m
á«a¶Úÿ0¶ìå