Re: [PATCH V6 3/6] perf, x86: large PEBS interrupt threshold

[Peter Zijlstra]

On Thu, Apr 09, 2015 at 12:37:43PM -0400, Kan Liang wrote:
> +	/*
> +	 * When the event is constrained enough we can use a larger
> +	 * threshold and run the event with less frequent PMI.
> +	 */
> +	if (0 && /* disable this temporarily */

This is a good hint your patches are ordered wrong.

> +	    (hwc->flags & PERF_X86_EVENT_AUTO_RELOAD)) {
> +		threshold = ds->pebs_absolute_maximum -
> +			x86_pmu.max_pebs_events * x86_pmu.pebs_record_size;
> +	} else {
> +		threshold = ds->pebs_buffer_base + x86_pmu.pebs_record_size;
> +	}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/