Re: [PATCH] tty: Remove leftover dependencies on PPC_OF

[Kevin Hao]

On Thu, Apr 16, 2015 at 10:20:59PM -0700, Guenter Roeck wrote:
> powerpc qemu runs fail with the current upstream kernel.
> Bisect points to commit 52d996270032 ("powerpc: kill PPC_OF").
> Unfortunately, that commit did not remove all instances of PPC_OF.
> Practical impact is that the serial driver used by powerpc qemu
> targets is no longer built into the test kernel.

Sorry for the break. This is a dependency issue. The patch 213dce3c17a6
("tty: kconfig: remove the superfluous dependency on PPC_OF") has already
been merged into tty-next, but still not propagate to upstream yet. I failed
to reminder Michael of this when the pulling request is sent to Linus.

Thanks,
Kevin
> 
> Fixes: 52d996270032 ("powerpc: kill PPC_OF")
> Cc: Kevin Hao <haokexin@xxxxxxxxx>
> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  drivers/tty/serial/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index d2501f01cd03..77471d3db8d3 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -835,7 +835,7 @@ config SERIAL_MCF_CONSOLE
>  
>  config SERIAL_PMACZILOG
>  	tristate "Mac or PowerMac z85c30 ESCC support"
> -	depends on (M68K && MAC) || (PPC_OF && PPC_PMAC)
> +	depends on (M68K && MAC) || PPC_PMAC
>  	select SERIAL_CORE
>  	help
>  	  This driver supports the Zilog z85C30 serial ports found on
> @@ -1153,7 +1153,7 @@ config SERIAL_OMAP_CONSOLE
>  
>  config SERIAL_OF_PLATFORM_NWPSERIAL
>  	tristate "NWP serial port driver"
> -	depends on PPC_OF && PPC_DCR
> +	depends on PPC_DCR
>  	select SERIAL_OF_PLATFORM
>  	select SERIAL_CORE_CONSOLE
>  	select SERIAL_CORE
> -- 
> 2.1.0
>

Attachment: pgpw8dDwNBUxU.pgp
Description: PGP signature