Re: [PATCH V4] Fix pointer cast for 32 bits arch

[Dan Carpenter]

Actually, my patch seems like a good idea to me but it's one of those
things that someone should probably test.  Unless someone can test
goldfish on a 32 bit system with 64 bit dma addresses then maybe the
thing to is to write the new function but preserve the current behavior.

static inline void gf_write_dma_addr(dma_addr_t addr, void __iomem *portl,
				     void __iomem *porth)
{
	writel((u32)data, portl);
	/*
	 * This should be CONFIG_ARCH_DMA_ADDR_T_64BIT but someone needs to
	 * test it.
	 */
#ifdef CONFIG_64BIT
	writel(data >> 32, porth);
#endif
}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/