Re: [PATCH v2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max
From: David Miller
Date: Fri Apr 17 2015 - 15:59:25 EST
From: Guenter Roeck <linux@xxxxxxxxxxxx>
Date: Fri, 17 Apr 2015 12:40:06 -0700
> On Fri, Apr 17, 2015 at 03:12:25PM -0400, Vivien Didelot wrote:
>> Since commit da4759c (sysfs: Use only return value from is_visible for
>> the file mode), it is possible to reduce the permissions of a file.
>>
>> So declare temp1_max with the DEVICE_ATTR_RW macro and remove the write
>> permission in dsa_hwmon_attrs_visible if set_temp_limit isn't provided.
>>
>> Signed-off-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>
>
> Looks good.
>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/