Re: [PATCH 02/14] MIPS: ath79: Add basic device tree support

[Alban]

On Sat, 18 Apr 2015 09:05:52 +0200
Paul Bolle <pebolle@xxxxxxxxxx> wrote:

> On Fri, 2015-04-17 at 16:24 +0200, Alban Bedel wrote:
> 
> > --- a/arch/mips/ath79/Kconfig
> > +++ b/arch/mips/ath79/Kconfig
> >  
> > +choice
> > +	prompt "Builtin devicetree selection"
> > +	default DTB_ATH79_NONE
> > +	help
> > +	  Select the devicetree.
> > +
> > +	config DTB_ATH79_NONE
> > +		bool "None"
> > +endchoice
> 
> This adds a choice block with one config entry. So what this achieves
> is that DTB_ATH79_NONE will always be 'y', right? Besides I didn't
> notice on a user of CONFIG_DTB_ATH79_NONE. So as far as I can see
> this choice has no effect on the build.
> 
> Why was this choice entry added?

This menu is for boards that need a built-in DTB, as MIPS currently
doesn't support appended DTBs it is the only way to load a DTB on
boards stuck with a broken boot loader. But as no board has been added
yet it only contain the entry for boards that don't need a built-in
DTB, which do nothing as you pointed out.

A board is then added in this menu in patch 14, for some reasons git
send-email didn't send the whole serie at once :(

Alban
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/