[PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()

[Mateusz Kulikowski]

Suggest using eth_zero_addr() or eth_broadcast_addr() if memset is used instead.

Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@xxxxxxxxx>
---
 scripts/checkpatch.pl | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3a1a01e..1fc0819 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5042,6 +5042,22 @@ sub process {
 				 "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . $herecurr)
 		}
 
+# check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr
+# check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr
+		if ($^V && $^V ge 5.10.0 &&
+			$line =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) {
+
+			my $ms_val = $7;
+
+			if ($ms_val =~ /^(0x|)0$/i) {
+				WARN("PREFER_ETH_ZERO_ADDR",
+					  "Prefer eth_zero_addr over memset()\n" . $herecurr);
+			} elsif ($ms_val =~ /^0xff$/i) {
+				WARN("PREFER_ETH_BROADCAST_ADDR",
+					  "Prefer eth_broadcast_addr() over memset()\n" . $herecurr);
+			}
+		}
+
 # typecasts on min/max could be min_t/max_t
 		if ($^V && $^V ge 5.10.0 &&
 		    defined $stat &&
-- 
1.8.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/