Re: [alsa-devel] [PATCH 1/2] extcon: arizona: Add support for select accessory detect mode when headphone detection"

[Charles Keepax]

On Mon, Apr 20, 2015 at 10:45:14AM +0900, Inha Song wrote:
> Hi,
> 
> Thanks for your comments,
> 
> 
> On Fri, 17 Apr 2015 10:00:47 +0100
> Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Fri, Apr 17, 2015 at 05:32:58PM +0900, Inha Song wrote:
> > > This patch add support for select accessory detect mode to HPDETL or HPDETR.
> > > Arizona provides a headphone detection circuit on the HPDETL and HPDETR pins
> > > to measure the impedance of an external load connected to the headphone.
> > > 
> > > Depending on board design, headphone detect pins can change to HPDETR or HPDETL.
> > > 
> > > Signed-off-by: Inha Song <ideal.song@xxxxxxxxxxx>
> > > ---
> > 
> > > +
> > >  	info->micvdd = devm_regulator_get(&pdev->dev, "MICVDD");
> > >  	if (IS_ERR(info->micvdd)) {
> > >  		ret = PTR_ERR(info->micvdd);
> > > @@ -1338,6 +1359,11 @@ static int arizona_extcon_probe(struct platform_device *pdev)
> > >  
> > >  	arizona_extcon_set_mode(info, 0);
> > >  
> > > +	if (arizona->pdata.hpdet_channel)
> > > +		info->hpdet_channel = ARIZONA_ACCDET_MODE_HPR;
> > > +	else
> > > +		info->hpdet_channel = ARIZONA_ACCDET_MODE_HPL;
> > > +
> > 
> > Just move the two defines in include/dt-bindings/mfd/arizona.h
> > and have the pdata get set directly to one of the values.
> 
> Ok, I agree. But I have a question.
> Should I also move ACCDET_MODE_MIC define to dt-bindings header?
> 

Yeah I think move that over too, there is a reasonable chance it
will be need as part of the binding at some point in the future.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/