Re: [PATCH 6/7] perf data: Fix duplicate field names and avoid reserved keywords

[Arnaldo Carvalho de Melo]

Em Sat, Apr 18, 2015 at 10:45:36PM +0200, Jiri Olsa escreveu:
> On Sat, Apr 18, 2015 at 02:56:00PM -0400, Jérémie Galarneau wrote:
> > On Sat, Apr 18, 2015 at 11:50 AM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> > > From: Wang Nan <wangnan0@xxxxxxxxxx>
> > >
> > > Some parameters of syscall tracepoints named as 'nr', 'event', etc.
> > > When dealing with them, perf convert to ctf meets some problem:
> > >
> > >  1. If a parameter with name 'nr', it will duplicate syscall's
> > >     common field 'nr'. One such syscall is io_submit().
> > >
> > >  2. If a parameter with name 'event', it is denied to be inserted
> > >     because 'event' is a babeltrace keywork. One such syscall is
> > >     epoll_ctl.
> > 
> > Minor nitpick: "event" is a reserved keyword in the CTF specification
> > [1], the rule is only enforced by Babeltrace. Also, keywork ->
> > keyword.
> 
> thanks,
> 
> Arnaldo, any chance you could change it? (with ack from

I'll do it

> He Kuang of course), or do you need a respin..
> 
> jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/