Re: [PATCH] spi: rb4xx: Fix set_cs logic.

From: Mark Brown
Date: Mon Apr 20 2015 - 16:37:18 EST


On Mon, Apr 20, 2015 at 03:53:25PM +0200, Bert Vermeulen wrote:
> As it turns out, the set_cs() enable parameter refers to the logic level
> on the CS pin, not the state of chip selection.

> This broke functionality of the LEDs behind the CPLD, or at least delayed
> the commands until another one came in to toggle CS.

No, the enable parameter *should* refer to chip select assertion (see
how we handle GPIO chip selects). However it's possible that this
device has an inverted chip select and should be registered with the
SPI_CS_HIGH flag?

Attachment: signature.asc
Description: Digital signature