Re: [PATCH v3 5/8] selftest/x86: build both bitnesses

[Andy Lutomirski]

On Mon, Apr 20, 2015 at 4:15 PM, Tyler Baker <tyler.baker@xxxxxxxxxx> wrote:
> Using uname with the processor flag option in some cases can yield 'unknown'
> so lets use the machine flag option as it is deterministic. Add a dependency
> for all_32 when building on a x86 64 bit host so that both bitnesses are
> built in this case.
>

Acked-by: Andy Lutomirski <luto@xxxxxxxxxx>

> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> Signed-off-by: Tyler Baker <tyler.baker@xxxxxxxxxx>
> ---
>  tools/testing/selftests/x86/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
> index ddf6356..be93945 100644
> --- a/tools/testing/selftests/x86/Makefile
> +++ b/tools/testing/selftests/x86/Makefile
> @@ -7,13 +7,13 @@ BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
>
>  CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>
> -UNAME_P := $(shell uname -p)
> +UNAME_M := $(shell uname -m)
>
>  # Always build 32-bit tests
>  all: all_32
>
>  # If we're on a 64-bit host, build 64-bit tests as well
> -ifeq ($(shell uname -p),x86_64)
> +ifeq ($(UNAME_M),x86_64)
>  all: all_64
>  endif
>
> --
> 2.1.4
>



-- 
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/