Re: [PATCH RFC] x86: enforce inlining for atomics

From: Peter Zijlstra
Date: Mon Apr 20 2015 - 19:46:38 EST


On Mon, Apr 20, 2015 at 11:27:11PM +0200, Hagen Paul Pfeifer wrote:
> During some code analysis I realized that atomic_add, atomic_sub and
> friends are not necessarily inlined AND that each function is defined
> multiple times:
>
> atomic_inc: 544 duplicates
> atomic_dec: 215 duplicates
> atomic_dec_and_test: 107 duplicates
> atomic64_inc: 38 duplicates
> [...]
>
> Each definition is exact equally, e.g.:
>
> ffffffff813171b8 <atomic_add>:
> 55 push %rbp
> 48 89 e5 mov %rsp,%rbp
> f0 01 3e lock add %edi,(%rsi)
> 5d pop %rbp
> c3 retq
>

Urgh, that's a GCC fail, what version and compile flags?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/