Re: [PATCH v3 3/4] ARM: dts: UniPhier: add support for UniPhier SoCs and boards

[Masahiro Yamada]

Hi Arnd,


2015-04-18 0:56 GMT+09:00 Arnd Bergmann <arnd@xxxxxxxx>:
> On Saturday 18 April 2015 00:48:17 Masahiro Yamada wrote:
>> +
>> +               smp_syscon@59801208 {
>> +                       compatible = "socionext,uniphier-smp-reg", "syscon";
>> +                       reg = <0x59801208 0x4>;
>> +               };
>> +
>>
>
> Using syscon here is a good idea, but please name the register area
> according to what it is called in the data sheet, not according to how
> it is used in Linux, and list all the registers that belong in this
> device. It's quite possible that another driver needs a second
> register from the same syscon.
>
> E.g. if there is a device called a foo controller, make this device
>
>         foo-controller@0x59800000 {
>                 compatible = "socionext,uniphier-foo-controller", "syscon";
>                 reg = <0x59800000 0x4000>;
>         };
>
> then hardcode the 0x1208 offset in the smp code, or add it as an
> argument to the property containing the phandle.
>

OK, I updated this part in v4.


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/