Re: [PATCH v2] perf tools: Document --children option in more detail

[Ingo Molnar]

* Namhyung Kim <namhyung@xxxxxxxxxx> wrote:

> Hi Ingo,
> 
> On Mon, Apr 20, 2015 at 08:04:11PM +0200, Ingo Molnar wrote:
> > 
> > * Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > 
> > > As the --children option changes the output of perf report (and perf
> > > top) it sometimes confuses users.  Add more words and examples to help
> > > understanding of the option's behavior - and how to disable it ;-).
> > 
> > Nice! :-)
> 
> Thanks! :)
> 
> > 
> > > +++ b/tools/perf/Documentation/overhead.txt
> > 
> > As some people might stumble upon this the old fashioned way, by 
> > looking around in 'Documentation/', I'm wondering how this file name 
> > will tell the reader that this is about call chains? (which isn't the 
> > default recording mode) Maybe name it more explicitly, like 
> > callchain-overhead.txt?
> 
> OK.  But I'd rather name it 'overhead-calculation.txt' to align with
> the section name.  And 'callchain-overhead' makes me thinking about
> the overhead of processing callchains at record or report time.

Sure!

> > s/perfconfig/.perfconfig
> > 
> > ?
> 
> It seems we can have a system-wide /etc/perfconfig too.  How about
> 'the perf config file' instead?

Yeah.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/