Re: [PATCH] staging: gdm72xx: enclose complex define statement

[Greg KH]

On Mon, Apr 20, 2015 at 10:11:51PM -0500, Jaime Arrocha wrote:
> This patch fixes the warning found by checkpatch.pl:
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: Jaime Arrocha <jarr@xxxxxxxxxxxxx>
> ---
>  drivers/staging/gdm72xx/usb_ids.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/gdm72xx/usb_ids.h b/drivers/staging/gdm72xx/usb_ids.h
> index 8ce544d..2b50ac6 100644
> --- a/drivers/staging/gdm72xx/usb_ids.h
> +++ b/drivers/staging/gdm72xx/usb_ids.h
> @@ -32,8 +32,8 @@
>  #define BL_PID_MASK		0xffc0
>  
>  #define USB_DEVICE_BOOTLOADER(vid, pid)	\
> -	{USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD)},	\
> -	{USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD|B_DIFF_DL_DRV)}
> +	({USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD)},	\
> +	{USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD|B_DIFF_DL_DRV)})

checkpatch isn't always correct.  This is one such example.

Does this even compile?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/