Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c

[Ian Abbott]

On 21/04/15 08:50, Greg KH wrote:
> On Mon, Apr 20, 2015 at 07:57:31PM -0700, Gbenga Adalumo wrote:
> > The patch fixes a trailing whitespace and code indenting coding style
> > errors as reported by checkpatch.pl tool.
> >   Details of the lines where the fixed errors were reported are as follows:
> >
> > drivers/staging/comedi/drivers/daqboard2000.c:43: ERROR: trailing whitespace
> > drivers/staging/comedi/drivers/daqboard2000.c:46: ERROR: code indent
> > should use tabs where possible
>
> <snip>
>
> You don't have to list all of the individual errors, and not in a
> line-wrapped way either.
>
> It looks like you are fixing different types of errors, so please
> provide different patches to do them.  Each patch should just do one
> thing.

All these "errors" occur in a single block comment.  It would be 
preferable if that block comment were reformatted to use the usual 
block-comment style:

/*
 * blah
 * blah
 */

This has already been done for some comedi drivers.

Thanks,
Ian A.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/