Re: [PATCH] tracing: Export key trace event symbols

[Ron Rechenmacher]

But why export anything _GPL in the first place?


Christoph Hellwig wrote on 04/21/15 08:23:
> On Tue, Apr 21, 2015 at 08:13:24AM -0500, Ron Rechenmacher wrote:
> > Hi Christoph,
> >
> > My module, and information about it, can be found at:
> > https://cdcvs.fnal.gov/redmine/projects/trace
> > https://cdcvs.fnal.gov/redmine/projects/trace/repository/show/src_module
> > with the header at
> > https://cdcvs.fnal.gov/redmine/projects/trace/repository/raw/include/trace.h
>
> And now send a patch including a rationale on why we need it.  I haven't
> looked deep enough, but so far I can't see any real value add in it.
>
> > It seems that you are the person that I have to convince in order to get
> > my patch accepted. Is this true?
>
> In the end you'll need to convince a maintainer to apply it.
>
> > Can you tell me how:
> > ./kernel/trace/power-traces.c:17:EXPORT_TRACEPOINT_SYMBOL_GPL(power_start);
>
> I can't find a tracepoint with that name in the current tree.
>
> > ./kernel/trace/power-traces.c:19:EXPORT_TRACEPOINT_SYMBOL_GPL(cpu_idle);
>
> This one is used by the potentially modular intel_idle (now cpuids)
> driver, so it's exported for a reason.
>
> > should be allowed (how it fits with your definition of the Linux kernel below) and
> > my proposed EXPORTS not?
> > I hope that you will not suggest removing the above 2 exports.
>
> It's perfectly fine to remove unused exports, and we do it regularly

--
Ron Rechenmacher
Engineer
Fermi National Accelerator Laboratory
Batavia, IL  60510
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/