Re: [PATCH] genirq: check irq_ack callback in handle_edge_irq() before calling

[Sam Protsenko]

On Tue, Apr 21, 2015 at 5:40 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> No, it's not missing by chance. It's missing on purpose. The edge
> handler is designed to deal with edge type interrupt chips and those
> have an ACK by definition.
>
> You are fixing the wrong place. That GPIO expander is using the wrong
> flow handler. It should not use the edge handler at all.

Just missed comments for handle_edge_irq() function, explaining why
irq_ack is mandatory. So I just need to use handle_level_irq() in expander
driver (instead of handle_edge_irq()).

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/