Re: [PATCH 6/8] clk: samsung: exynos5800: fix cpu clock configuration data

[Lukasz Majewski]

Hi Bartlomiej,

> Fix cpu clock configuration data for Exynos5800 (it uses
> higher PCLK_DBG divider values than Exynos5420 and supports
> additional frequencies).
> 
> Based on Hardkernel's kernel for ODROID-XU3 board.
> 
> Cc: Tomasz Figa <tomasz.figa@xxxxxxxxx>
> Cc: Mike Turquette <mturquette@xxxxxxxxxx>
> Cc: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
> Cc: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> ---
>  drivers/clk/samsung/clk-exynos5420.c |   36
> +++++++++++++++++++++++++++++++--- 1 file changed, 33 insertions(+),
> 3 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos5420.c
> b/drivers/clk/samsung/clk-exynos5420.c index 9398a2d..462aaee 100644
> --- a/drivers/clk/samsung/clk-exynos5420.c
> +++ b/drivers/clk/samsung/clk-exynos5420.c
> @@ -1274,10 +1274,34 @@ static const struct exynos_cpuclk_cfg_data
> exynos5420_eglclk_d[] __initconst = { {  0 },
>  };
>  
> +static const struct exynos_cpuclk_cfg_data exynos5800_eglclk_d[]
> __initconst = {
> +	{ 2000000, E5420_EGL_DIV0(3, 7, 7, 4), },
> +	{ 1900000, E5420_EGL_DIV0(3, 7, 7, 4), },
> +	{ 1800000, E5420_EGL_DIV0(3, 7, 7, 4), },
> +	{ 1700000, E5420_EGL_DIV0(3, 7, 7, 3), },
> +	{ 1600000, E5420_EGL_DIV0(3, 7, 7, 3), },
> +	{ 1500000, E5420_EGL_DIV0(3, 7, 7, 3), },
> +	{ 1400000, E5420_EGL_DIV0(3, 7, 7, 3), },
> +	{ 1300000, E5420_EGL_DIV0(3, 7, 7, 2), },
> +	{ 1200000, E5420_EGL_DIV0(3, 7, 7, 2), },
> +	{ 1100000, E5420_EGL_DIV0(3, 7, 7, 2), },
> +	{ 1000000, E5420_EGL_DIV0(3, 7, 6, 2), },
> +	{  900000, E5420_EGL_DIV0(3, 7, 6, 2), },
> +	{  800000, E5420_EGL_DIV0(3, 7, 5, 2), },
> +	{  700000, E5420_EGL_DIV0(3, 7, 5, 2), },
> +	{  600000, E5420_EGL_DIV0(3, 7, 4, 2), },
> +	{  500000, E5420_EGL_DIV0(3, 7, 3, 2), },
> +	{  400000, E5420_EGL_DIV0(3, 7, 3, 2), },
> +	{  300000, E5420_EGL_DIV0(3, 7, 3, 2), },
> +	{  200000, E5420_EGL_DIV0(3, 7, 3, 2), },
> +	{  0 },
> +};
> +
>  #define E5420_KFC_DIV(kpll, pclk,
> aclk)					\ ((((kpll) << 24) |
> ((pclk) << 20) | ((aclk) << 4))) 
>  static const struct exynos_cpuclk_cfg_data exynos5420_kfcclk_d[]
> __initconst = {
> +	{ 1400000, E5420_KFC_DIV(3, 5, 3), }, /* for Exynos5800 */
>  	{ 1300000, E5420_KFC_DIV(3, 5, 2), },
>  	{ 1200000, E5420_KFC_DIV(3, 5, 2), },
>  	{ 1100000, E5420_KFC_DIV(3, 5, 2), },
> @@ -1357,9 +1381,15 @@ static void __init exynos5x_clk_init(struct
> device_node *np, ARRAY_SIZE(exynos5800_gate_clks));
>  	}
>  
> -	exynos_register_cpu_clock(ctx, CLK_ARM_CLK, "armclk",
> -		mout_cpu_p[0], mout_cpu_p[1], 0x200,
> -		exynos5420_eglclk_d,
> ARRAY_SIZE(exynos5420_eglclk_d), 0);
> +	if (soc == EXYNOS5420) {
> +		exynos_register_cpu_clock(ctx, CLK_ARM_CLK, "armclk",
> +			mout_cpu_p[0], mout_cpu_p[1], 0x200,
> +			exynos5420_eglclk_d,
> ARRAY_SIZE(exynos5420_eglclk_d), 0);
> +	} else {
> +		exynos_register_cpu_clock(ctx, CLK_ARM_CLK, "armclk",
> +			mout_cpu_p[0], mout_cpu_p[1], 0x200,
> +			exynos5800_eglclk_d,
> ARRAY_SIZE(exynos5800_eglclk_d), 0);
> +	}
>  	exynos_register_cpu_clock(ctx, CLK_KFC_CLK, "kfcclk",
>  		mout_kfc_p[0], mout_kfc_p[1], 0x28200,
>  		exynos5420_kfcclk_d,
> ARRAY_SIZE(exynos5420_kfcclk_d), 0);

Reviewed-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/