Re: [PATCH 3/3] libata: Change medium_power LPM policy to match Intel recommendations

From: Tejun Heo
Date: Wed Apr 22 2015 - 10:52:09 EST


On Sat, Apr 18, 2015 at 08:26:36AM -0700, Matthew Garrett wrote:
> Intel publish a document on designing energy efficient SATA devices at
> http://www.intel.com/content/dam/doc/reference-guide/sata-devices-implementation-recommendations.pdf
> which recommends that ALPE be set, ASPE be cleared and that DIPM be enabled
> on the device. Right now we have no policy that matches that - medium_power
> does not enable DIPM and min_power sets ASPE. Change medium_power to
> implement these recommendations, with the addition of devslp state being
> inherited from the initial configuration. With luck this will provide
> reasonable power savings without causing the device breakages we
> occasionally see with the min_power policy.

Can we add comment explaining what med_power implements and link to
the above?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/