Re: [PATCH 01/16] x86, fpu: wrap get_xsave_addr() to make it safer
From: Dave Hansen
Date: Wed Apr 22 2015 - 12:02:24 EST
On 04/22/2015 08:17 AM, Thomas Gleixner wrote:
> On Wed, 22 Apr 2015, Dave Hansen wrote:
>> On 04/22/2015 06:31 AM, Borislav Petkov wrote:
>>> I read tsk_get_xsave_field(@tsk, ) as give me the xsave field of @tsk
>>> but doing used_math() we're querying current and I'm not sure
>>>
>>> tsk == current
>>>
>>> in all the call sites of tsk_get_xsave_field().
>>
>> There aren't that many call sites. :)
>>
>> But, yeah, tsk==current for all of them at the moment.
>
> Is there a reason to have the task argument at all if thats only
> intended for current?
No, there is no good reason. I'll rework it and resend the set.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/