Re: [tpmdd-devel] [PATCH v2] tpm: enable PPI for TPM 2.0

[Greg Kroah-Hartman]

On Wed, Apr 22, 2015 at 11:22:43AM -0600, Jason Gunthorpe wrote:
> On Wed, Apr 22, 2015 at 07:38:55PM +0300, Jarkko Sakkinen wrote:
> > > > > +EXPORT_SYMBOL_GPL(kernfs_remove_by_name_ns);
> > > > 
> > > > ??
> > > > I don't see this being called
> > > 
> > > My bad, it is clutter in the patch file. I'll remove it.
> > 
> > In fact this is needed because the driver uses kernfs_remove_by_name,
> > which is an inline function that uses kernfs_remove_by_name_ns
> > internally.
> 
> Hum, that probably needs a sysfs_ analog - the paired removal
> function for sysfs_link_group_to_kobj ?

Be very careful using that sysfs function, you shouldn't be doing that
within a driver subsystem unless you know what you are doing :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/