Re: [PATCH 2/6] mtd: diskonchip: don't call nand_scan_bbt() directly

From: RafaÅ MiÅecki
Date: Thu Apr 23 2015 - 03:50:17 EST


On 23 April 2015 at 02:30, Peter Pan ææ (peterpandong)
<peterpandong@xxxxxxxxxx> wrote:
> On Thu, Apr 23, 2015 at 01:51:27PM +0000, Brian Norris wrote:
>>
>> On Thu, Apr 16, 2015 at 02:11:24AM +0000, Peter Pan ææ (peterpandong)
>> wrote:
>> > The diskonchip driver almost uses the default nand_base hooks as-is,
>> > except that it provides custom on-flash BBT descriptors and avoids
>> using
>> > factory-marked bad blockers.
>> >
>> > So let's refactor the BBT initialization code into a private
>> 'late_init'
>> > hook which handles all the private details. Note the usage of
>> > NAND_SKIP_BBTSCAN, which allows us to defer the BBT scan until we've
>> > prepared everything.
>> >
>> > Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx>
>> > Signed-off-by: Peter Pan <peterpandong@xxxxxxxxxx>
>>
>> Why are you just resending my patch? You could Ack/Review/Test it
>> instead. (Did you test it?)
>
> My work is in the 6th patch.
> I already tested the patch with micron own nand controller. I don't have
> platform with docg4 or diskonchip controller. So the BBT and nand_base.c
> part is covered while docg4.c and diskonchip.c not.

You can use patch format's comment place to post sth like
"Depends on 5 XXX patches from Brian"

--
RafaÅ
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/