Re: [PATCH v2 3/4] of: overlay: Add sysfs attributes

From: Greg KH
Date: Thu Apr 23 2015 - 09:04:30 EST


On Thu, Apr 23, 2015 at 03:59:02PM +0300, Pantelis Antoniou wrote:
> >>>> Itâs the same reason that the device tree core is using it.
> >>>
> >>> It is doing that for "raw" device tree files, not individual attributes,
> >>> right?
> >>>
> >>
> >> Each property of a device tree is a binary attribute.
> >
> > Because they export binary data, right? I don't have access to a
> > machine that uses device tree at the moment to check this...
> >
> > Any specific file/function you are referring to?
> >
>
> Yes, they export binary data. It works because the device tree nodes
> are raw kobjs.

Great, then the device tree is doing this correctly :)

For text files, use real attribute files, that's the proper way to
handle sysfs from kobjects.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/