Re: Re: [PATCH perf/core 5/8] perf probe: Allow to use filter on --del command

[Masami Hiramatsu]

(2015/04/22 22:56), Namhyung Kim wrote:
> On Tue, Apr 21, 2015 at 08:42:06PM +0900, Masami Hiramatsu wrote:
>> -int del_perf_probe_events(struct strlist *dellist)
>> +int del_perf_probe_events(struct strfilter *filter)
>>  {
>> -	int ret = -1, ret2, ufd = -1, kfd = -1;
>> -	char buf[128];
>> -	const char *group, *event;
>> -	char *p, *str;
>> -	struct str_node *ent;
>> +	int ret = 0, ufd = -1, kfd = -1;
>>  	struct strlist *namelist = NULL, *unamelist = NULL;
>> +	char *str = strfilter__string(filter);
> 
> You may want to check the return value here - or in the
> strfilter__string() ?

Ah, right. Even though this str is only for debugging, it
is better to verify the filter is correctly built by
strfilter__string.

I'll check the return value here.

> 
> Thanks,
> Namhyung
> 
> 
>> +
>> +	pr_debug("Filter: \'%s\'\n", str);
> 
> [SNIP]
>> +char *strfilter__string(struct strfilter *filter)
>> +{
>> +	int len;
>> +	char *ret = NULL;
>> +
>> +	len = strfilter_node__sprint(filter->root, NULL);
>> +	if (len < 0)
>> +		return NULL;
>> +
>> +	ret = malloc(len + 1);
> 
> Here?

Oops, of course there need another check :)
this is just a simple care-less miss.

Thanks again!

> 
>> +	strfilter_node__sprint(filter->root, ret);
>> +
>> +	return ret;
>> +}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/