Re: [PATCH] lib/scatterlist: fix kerneldoc for sg_pcopy_{to,from}_buffer()

[Akinobu Mita]

2015-04-23 22:57 GMT+09:00 Dave Gordon <david.s.gordon@xxxxxxxxx>:
> The kerneldoc for the functions doesn't match the code; the
> last two parameters (buflen, skip) have been transposed, which
> is confusing, especially as they're both integral types and the
> compiler won't warn about swapping them.
>
> These functions and the kerneldoc were introduced in commit:
>     df642cea lib/scatterlist: introduce sg_pcopy_from_buffer() ...
>     Author: Akinobu Mita <akinobu.mita@xxxxxxxxx>
>     Date:   Mon Jul 8 16:01:54 2013 -0700
>
>     The only difference between sg_pcopy_{from,to}_buffer() and
>     sg_copy_{from,to}_buffer() is an additional argument that
>     specifies the number of bytes to skip the SG list before
>     copying.

Thanks for fixing this.

Reviewed-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/