Re: [PATCH 7/8] ASoC: wm8998: Initial WM8998 codec driver

From: Mark Brown
Date: Thu Apr 23 2015 - 13:55:20 EST


On Thu, Apr 23, 2015 at 03:28:23PM +0100, Richard Fitzgerald wrote:

> I'm not sure this is really a routing or widget problem. Problem is that
> if the muxed inputs are analogue we need to provide separate ALSA controls
> for the left and right mux because it is allowed to use them as two
> independant mono channels with separate muxing. But if they are
> configured as digital the mux controls are ganged so must be set the

I understand this, it's what prompted my comment.

> same. I don't feel good about registering a single mux control if its
> digital and two if its analogue because that means the codec's control
> list depends on a pdata option. I could implement the control pair

I don't see that as a problem, it's not like the disallowed options
would ever meaningfully exist for users on an affected system. Why do
you see this as a problem?

Attachment: signature.asc
Description: Digital signature