Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

From: Dmitry Torokhov
Date: Thu Apr 23 2015 - 14:20:55 EST


On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote:
> > "Creation, replacement and destruction of contacts is achieved by
> > modifying the ABS_MT_TRACKING_ID of the associated slot. A
> > non-negative tracking id is interpreted as a contact, and the value -1
> > denotes an unused slot. A tracking id not previously present is
> > considered new, and a tracking id no longer present is considered
> > removed."
> >
> > If some userspace is confused with missing -1 tracking ID for that
> > slot, that userspace should be fixed.
>
> I agree. Some userland applications work with add/remove out of convenience, and
> cannot handle the more compressed notation the kernel slot handling allows.
> Fixing those applications will be a good thing.
>
> Unfortunately the patch already appeared in Linus' tree...

It's in 4.1-rc0 so we can just revert it.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/