RE: [PATCH v6 1/2] Devicetree: Add pl353 smc controller devicetree binding information

[Punnaiah Choudary Kalluri]

Hi Josh,

> -----Original Message-----
> From: Josh Cartwright [mailto:joshc@xxxxxx]
> Sent: Friday, April 24, 2015 1:21 AM
> To: Punnaiah Choudary Kalluri
> Cc: robh+dt@xxxxxxxxxx; pawel.moll@xxxxxxx; mark.rutland@xxxxxxx;
> ijc+devicetree@xxxxxxxxxxxxxx; galak@xxxxxxxxxxxxxx; rob@xxxxxxxxxxx;
> Michal Simek; grant.likely@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx;
> jason@xxxxxxxxxxxxxx; ezequiel.garcia@xxxxxxxxxxxxxxxxxx;
> arnd@xxxxxxxx; dwmw2@xxxxxxxxxxxxx; computersforpeace@xxxxxxxxx;
> artem.bityutskiy@xxxxxxxxxxxxxxx; jussi.kivilinna@xxxxxx;
> acourbot@xxxxxxxxxx; ivan.khoronzhuk@xxxxxx; joern@xxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; kpc528@xxxxxxxxx;
> kalluripunnaiahchoudary@xxxxxxxxx; Punnaiah Choudary Kalluri
> Subject: Re: [PATCH v6 1/2] Devicetree: Add pl353 smc controller devicetree
> binding information
> 
> Hey Punnaiah-
> 
> A few nitpicks here, in case you'll be spinning up a new version of your
> patchset.
> 
> On Mon, Apr 13, 2015 at 09:41:51PM +0530, Punnaiah Choudary Kalluri wrote:
> > Add pl353 static memory controller devicetree binding information.
> >
> > Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xxxxxxxxxx>
> [..]
> > @@ -0,0 +1,37 @@
> > +Device tree bindings for ARM PL353 static memory controller
> > +
> > +PL353 static memory controller supports two kinds of memory
> > +interfaces. i.e NAND and SRAM/NOR interfaces.
> > +The actual devices are instantiated from the child nodes of pl353 smc
> node.
> > +
> > +Required properties:
> > +- compatible		: Should be "arm,pl353-smc-r2p1"
> > +- reg			: Controller registers map and length.
> > +- clock-names		: List of input clock names - "memclk", "aclk"
> > +			  (See clock bindings for details).
> > +- clocks		: Clock phandles (see clock bindings for details).
> 
> Technically not clock phandles, but clock specifiers.
> 
> > +- address-cells	: Address cells, must be 1.
> > +- size-cells		: Size cells. Must be 1.
> 
> These should have the leading '#' as in '#address-cells' and
> '#size-cells'.

Thanks for the review. I will take care of them new version

Regards,
Punnaiah
> 
>   Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/