Re: [PATCH 2/2] block: remove unused BIO_RW_BLOCK and BIO_EOF flags

[Jeff Moyer]

Christoph Hellwig <hch@xxxxxx> writes:

> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index c2ee937..b0a5bff 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -112,8 +112,6 @@ struct bio {
>   * bio flags
>   */
>  #define BIO_UPTODATE	0	/* ok after I/O completion */
> -#define BIO_RW_BLOCK	1	/* RW_AHEAD set, and read/write would block */
> -#define BIO_EOF		2	/* out-out-bounds error */
>  #define BIO_SEG_VALID	3	/* bi_phys_segments valid */
>  #define BIO_CLONED	4	/* doesn't own data */
>  #define BIO_BOUNCED	5	/* bio is a bounce bio */

Any particular reason you elected to leave a hole in the numbering?  I
don't have a preference either way, but I don't think there's any harm
in compressing it.

-Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/