Re: [PATCH V2 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers

From: Mark Brown
Date: Sat Apr 25 2015 - 07:35:27 EST


On Fri, Apr 24, 2015 at 03:36:47PM -0700, Kevin Cernekee wrote:

> + gpiod_set_value(priv->pdn_gpio, 0);
> + usleep_range(5000, 6000);
> +
> + regcache_cache_only(priv->regmap, false);
> + ret = regcache_sync_region(priv->regmap, 0,
> + priv->chip->regmap_config->max_register, false);
> + if (ret)
> + return ret;

This is also a problem with your first patch BTW - even if we are going
to add an argument we shouldn't be having drivers do _sync_region() to
sync the entire register map, that's just ugly.

Attachment: signature.asc
Description: Digital signature