Re: [PATCH v2 1/2] libata: Add helper to determine when PHY events should be ignored

[Tejun Heo]

On Sat, Apr 25, 2015 at 07:52:36PM +0200, Gabriele Mazzotta wrote:
> +bool sata_lpm_ignore_phy_events(struct ata_link *link)
> +{
> +	/* if LPM is enabled, PHYRDY doesn't mean anything */
> +	return !!(link->lpm_policy > ATA_LPM_MAX_POWER);

This gets removed by the next patch so it doesn't matter but there's
no need to do !! here.  The expression is already bool and even if not
casting to bool can't yield any other result.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/