Re: [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board

From: Heiko Stübner
Date: Sun Apr 26 2015 - 06:16:34 EST


Hi,

Am Sonntag, 26. April 2015, 17:41:39 schrieb Yunzhi Li:
> rk3288-firefly board use the dwc2 usb otg controller as a host
> controller and the device mode not used, so the dr_mode should be
> "host" then the dwc2 usb otg controller will work at host only
> mode
>
> Signed-off-by: Yunzhi Li <lyz@xxxxxxxxxxxxxx>

Not sure I understand. Is this some sort of hardware limitation? Because when
for example flashing a kernel via upgrade_tool it is working just fine as
gadget.

If it is a software choice, this should not be made in the devicetree, as the
dt describes the hardware alone.


Heiko


>
> ---
>
> arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi
> b/arch/arm/boot/dts/rk3288-firefly.dtsi index e6f873a..a861776 100644
> --- a/arch/arm/boot/dts/rk3288-firefly.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
> @@ -466,6 +466,7 @@
> };
>
> &usb_otg {
> + dr_modr = "host";
> status = "okay";
> };

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/