[PATCH v3 0/4] new ethernet address manipulation checks
From: Mateusz Kulikowski
Date: Sun Apr 26 2015 - 12:43:38 EST
Changes in v3:
- Fixed handling of MEMSET issues (due to '/s' at the end the same
error/warning was reported several times)
- Added handling of multiline PREFER_ETHER_ADDR_COPY warnings
- Review: added --fix option to eth_zero/broadcast_addr checks
- All new warnings are multi-line aware (fixes work on single lines only)
Changes in v2 (applied review comments):
- Fixed indentation in both patches
- Detect memset(foo, 0x00, ETH_ALEN)
- Detect memset(foo, 255, ETH_ALEN)
- Rephrased 2/2 commit message
Patch Notes from v1:
Add 3 new warnings to checkpatch:
1) PREFER_ETHER_ADDR_EQUAL
Replace memcmp(foo, bar, ETH_ALEN) with ether_addr_equal*()
2) PREFER_ETH_ZERO_ADDR
Replace memset(foo, 0, ETH_ALEN) with eth_zero_addr()
3) PREFER_ETH_BROADCAST_ADDR
Replace memset(foo, 0xFF, ETH_ALEN) with eth_broadcast_addr()
Mateusz Kulikowski (4):
checkpatch: suggest using ether_addr_equal*()
checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()
checkpatch: Fix processing of MEMSET issues
checkpatch: Add multi-line handling for PREFER_ETHER_ADDR_COPY
scripts/checkpatch.pl | 38 +++++++++++++++++++++++++++++++++++---
1 file changed, 35 insertions(+), 3 deletions(-)
--
1.8.4.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/