Re: [RFC PATCH 1/6] sched/rt: Provide new check_preempt_equal_prio_common()

[Steven Rostedt]

On Mon, 27 Apr 2015 01:10:53 +0800
Xunlei Pang <xlpang@xxxxxxx> wrote:

> From: Xunlei Pang <pang.xunlei@xxxxxxxxxx>
> 
> When p is queued, there may be other tasks already queued at the
> same priority in the "run queue", so we should peek the most front
> one to do the equal priority preemption.
> 
> This patch modifies check_preempt_equal_prio() and provides new
> check_preempt_equal_prio_common() to do the common preemption.

This change log fails to explain why this is needed.

> 
> There are also other cases to be added calling the new interface
> in the following patches.

A change log should stand on its own, and not just say, other patches
will use it. It can say that, if it fully explains why the change is
needed.

Also note, you are missing a 0/6 email that explains the entire
rational of the patch set, such that people understand more what you
intend to accomplish. We have no idea what your overall goal is.

-- Steve

> 
> Signed-off-by: Xunlei Pang <pang.xunlei@xxxxxxxxxx>
> ---
>  kernel/sched/rt.c | 70 ++++++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 54 insertions(+), 16 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/