Re: [PATCH] lib/sort: Add 64 bit swap function

[Rasmus Villemoes]

On Mon, Apr 27 2015, Daniel Wagner <daniel.wagner@xxxxxxxxxxxx> wrote:

> static int cmp_32(const void *a, const void *b)
> {
> 	return (int) (*(u32 *)a - *(u32 *)b);
> }
>
> static int cmp_64(const void *a, const void *b)
> {
> 	return (int) (*(u64 *)a - *(u64 *)b);
> }
>

Please [1] don't [2] do [3] this [4].

[1] acbbe6fbb240a927ee1f5994f04d31267d422215 kcmp: fix standard comparison bug

[2] ef17af2a817db97d42dd2ec0a425231748e23dbc fs: nfsd: Fix signedness bug in compare_blob

[3] ddbc22e27e672b6b180757ea1d7f8481dbb88128 fs/hfs/catalog.c: fix comparison bug in hfs_cat_keycmp

[4] 72392ed0eb6fde96826cb9d66bd4f50a7ba61450 kernfs: Fix kernfs_name_compare

(sorry for not actually looking at the patch - this just triggered one
of my pet peeves).

Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/