Re: [PATCH 11/13] mm: meminit: Free pages in large chunks where possible

[Andrew Morton]

On Thu, 23 Apr 2015 11:33:14 +0100 Mel Gorman <mgorman@xxxxxxx> wrote:

> Parallel struct page frees pages one at a time. Try free pages as single
> large pages where possible.
> 
> ...
>
>  void __defermem_init deferred_init_memmap(int nid)

This function is gruesome in an 80-col display.  Even the code comments
wrap, which is nuts.  Maybe hoist the contents of the outermost loop
into a separate function, called for each zone?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/