Re: [PATCH v9 07/17] h8300: miscellaneous functions

[Yoshinori Sato]

At Mon, 27 Apr 2015 10:57:10 +0200,
Arnd Bergmann wrote:
> 
> On Monday 27 April 2015 14:35:14 Yoshinori Sato wrote:
> > +void dma_sync_single_for_device(struct device *dev, dma_addr_t handle,
> > +				size_t size, enum dma_data_direction dir)
> > +{
> > +}
> > +EXPORT_SYMBOL(dma_sync_single_for_device);
> > +
> > +void dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> > +			    int nents, enum dma_data_direction dir)
> > +{
> > +	int i;
> > +
> > +	for (i = 0; i < nents; sg++, i++)
> > +		dma_sync_single_for_device(dev, sg->dma_address,
> > +					   sg->length, dir);
> > +}
> > +EXPORT_SYMBOL(dma_sync_sg_for_device);
> > +
> > +dma_addr_t dma_map_single(struct device *dev, void *addr, size_t size,
> > +			  enum dma_data_direction dir)
> > +{
> > +	dma_addr_t handle = virt_to_bus(addr);
> > +
> > +	dma_sync_single_for_device(dev, handle, size, dir);
> > +	return handle;
> > +}
> > +EXPORT_SYMBOL(dma_map_single);
> 
> 
> As this all doesn't do anything, and your dma-mapping.h header explains
> that the architecture is cache-coherent, just remove these functions,
> and replace them with empty 'static inline' helpers in that header.
> 
> 	Arnd
> 

OK.
This DMA support part too old.
I will rewriting.
Thanks.

-- 
Yoshinori Sato
<ysato@xxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/