Re: [PATCH v9 00/17] Re-introduce h8300 architecture

[Yoshinori Sato]

At Mon, 27 Apr 2015 11:11:28 +0200,
Arnd Bergmann wrote:
> 
> On Monday 27 April 2015 14:35:07 Yoshinori Sato wrote:
> > Hello.
> > I will re-introducing h8300.
> > 
> 
> I've done one more pass through all of your code. Generally I think you
> should at this point ask Stephen Rothwell to add your git tree to linux-next,
> and not rewrite the patches any more but instead add patches on top to fix
> the remaining issues.

OK.

> My comments are in several areas:
> 
> - device initialization. This should be updated to use a more modern version
>   and replace the use of early_platform and static platform_device definitions.
>

Hmm...
A variant isn't probably added, so I think there are no advantages
that DeviceTree is adopted.
It's considered.

> - asm/io.h needs should be rethought

OK.

> - header files that are functionally identical to the asm-generic variant
>   and could be replaced with a 'generic-y' Makefile statement

OK.

> I think all of these should be addressed, but they are not big issues that
> would stop you from merging the code in linux-4.2.
> 
> 	Arnd

Thanks.

-- 
Yoshinori Sato
<ysato@xxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/