Re: [PATCH 1/2] x86/asm/entry/64: Tidy up JZ insns after TESTs

[Denys Vlasenko]

On 04/28/2015 12:16 AM, H. Peter Anvin wrote:
> On 04/27/2015 06:21 AM, Denys Vlasenko wrote:
>>
>> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
>> index e952f6b..8f8b22a 100644
>> --- a/arch/x86/kernel/entry_64.S
>> +++ b/arch/x86/kernel/entry_64.S
>> @@ -666,7 +666,7 @@ END(irq_entries_start)
>>  	leaq -RBP(%rsp),%rdi	/* arg1 for \func (pointer to pt_regs) */
>>  
>>  	testl $3, CS-RBP(%rsp)
>> -	je 1f
>> +	jz	1f
>>  	SWAPGS
>>  1:
> 
> Please don't insert tabs between opcode and operand unless that is the
> style of the surrounding code.

The next patch inserts tab in the preceding TEST insn too,
converting entire mini-block of code to "tab" style.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/