RE: [PATCH v6] extcon-axp288: Add axp288 extcon driver support

[Pallala, Ramakrishna]

Hi Lee Jones,

I have agreed to move the AXP288_EXTCON_* macros to driver source file as
Choi is going to submit another extcon class driver patch to fix the consumer driver
access issue.

I will submit the v7 patch now with this change. Thank you for your time.

> > This patch adds the extcon support for AXP288 PMIC which has the BC1.2
> > charger detection capability. Additionally it also adds the USB mux
> > switching support b/w SOC and PMIC based on GPIO control.
> >
> > Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@xxxxxxxxx>
> > ---
> >  drivers/extcon/Kconfig         |    7 +
> >  drivers/extcon/Makefile        |    1 +
> >  drivers/extcon/extcon-axp288.c |  399
> ++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/axp20x.h     |    9 +
> >  4 files changed, 416 insertions(+)
> >  create mode 100644 drivers/extcon/extcon-axp288.c
> 
> [...]
> 
> > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> > index dfabd6d..38653e0 100644
> > --- a/include/linux/mfd/axp20x.h
> > +++ b/include/linux/mfd/axp20x.h
> > @@ -275,4 +275,13 @@ struct axp20x_fg_pdata {
> >  	int thermistor_curve[MAX_THERM_CURVE_SIZE][2];
> >  };
> >
> > +#define AXP288_EXTCON_SLOW_CHARGER		"SLOW-CHARGER"
> > +#define AXP288_EXTCON_DOWNSTREAM_CHARGER	"CHARGE-
> DOWNSTREAM"
> > +#define AXP288_EXTCON_FAST_CHARGER		"FAST-CHARGER"
> > +
> > +struct axp288_extcon_pdata {
> > +	/* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */
> > +	struct gpio_desc *gpio_mux_cntl;
> > +};
> > +
> >  #endif /* __LINUX_MFD_AXP20X_H */
> 
> Not sure what you decided since sending this, but in order for me to avoid
> becoming the bottle-neck:
> 
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

Thanks,
Ram