Re: [PATCH 01/11] coresight-etm4x: Adding CoreSight ETM4x driver

[Mathieu Poirier]

On 28 April 2015 at 02:30, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote:
>
> On Mon, 2015-04-27 at 09:48 -0600, Mathieu Poirier wrote:
>> On 24 April 2015 at 09:41, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote:
>> > On Wed, 2015-04-22 at 16:40 -0600, Mathieu Poirier wrote:
>> >
>> > > +static struct amba_id etm4_ids[] = {
>> > > +       {       /* ETM 4.0 - Hi6220 board */
>> > > +               .id     = 0x0003b95d,
>> > > +               .mask   = 0x0003ffff,
>> > > +               .data   = "ETM 4.0",
>> > > +       },
>> > > +       {       /* ETM 4.0 - Juno board */
>> > > +               .id     = 0x000bb95e,
>> > > +               .mask   = 0x000bffff,
>> >
>> > Mask looks suspicious.
>>
>> Can you please expand the "suspicious" part ?
>
> Well, 'b' part of the mask. I have to admit that
> I don't know how this is mapped on this platform.

Yes, I see it now - thanks for pointing that out.

>
> Regards,
> Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/