Re: [PATCH RFC] net/macb: Fix UDPv4 checksum offload

[David Miller]

From: Jaeden Amero <jaeden.amero@xxxxxx>
Date: Tue, 28 Apr 2015 15:36:54 -0500

> On 04/27/2015 09:47 PM, David Miller wrote:
>> From: Jaeden Amero <jaeden.amero@xxxxxx>
>> Date: Mon, 27 Apr 2015 17:43:30 -0500
>>
>> A UDP checksum of zero, means "checksum not computed".  And your
>> device isn't computing the checksum at all, but rather is leaving it
>> at zero.
> 
> The "zero" checksum is not what gets sent over the wire. Independent of
> the value of the checksum field, hardware generates a correct checksum
> for payloads of 3 or more bytes. The bug is that hardware generates an
> incorrect checksum for payloads of 2 or less bytes, unless the checksum
> field is zeroed.

Ok, then you need to add a comment here, because other people might come
to the same conclusion I did.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/