Re: [PATCH 02/10] block: simplify bio_add_page()

[Ming Lin]

On Tue, Apr 28, 2015 at 5:12 AM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Mon, Apr 27, 2015 at 11:48:29PM -0700, Ming Lin wrote:
>> Note that removing call to ->merge_bvec_fn() is fine for
>> bio_add_pc_page(), as SCSI devices usually don't even need that.
>> Few exceptional cases like pscsi or osd are not affected either.
>
> This explanation confuses me.  Based on my reading of the code I'd
> replace it with something like:
>
> Removing the call to ->merge_bvec_fn() is also fine, as no driver that
> implements support for BLOCK_PC commands even has a ->merge_bvec_fn()
> method.

Will update it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/