Re: [PATCHv3 08/11] usb: dwc3: add hsphy_interface property

[Heikki Krogerus]

> > +	/* Select the HS PHY interface */
> > +	switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc->hwparams.hwparams3)) {
> > +	case DWC3_GHWPARAMS3_HSPHY_IFC_UTMI_ULPI:
> > +		if (!strncmp(dwc->hsphy_interface, "utmi", 4)) {
> > +			reg &= ~DWC3_GUSB2PHYCFG_ULPI_UTMI;
> > +		} else if (!strncmp(dwc->hsphy_interface, "ulpi", 4)) {
> > +			reg |= DWC3_GUSB2PHYCFG_ULPI_UTMI;
> > +		} else {
> > +			dev_err(dwc->dev, "HSPHY Interface not defined\n");
> > +			return -EINVAL;
> 
> instead of erroring out, just leave default value and convert this to a
> dev_warn() or something similar. That way, older DTS will continue to
> work.

OK, I'll change it.

Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/