Re: [PATCHv3 06/11] usb: dwc3: soft reset to it's own function

From: Heikki Krogerus
Date: Wed Apr 29 2015 - 04:16:34 EST


> > + * dwc3_soft_reset - Issue soft reset
> > + * @dwc: Pointer to our controller context structure
> > + */
> > +static int dwc3_soft_reset(struct dwc3 *dwc)
>
> I don't see this being called anywhere else in your series and I would
> really like to know when we would need to reset the core again ?
>
> I don't oppose to having this split to own function because I rather
> like how it looks, but I don't want to reset the IP needlessly either.

This series seems to be missing the last patch for dwc3, where I
actually add the ULPI support to dwc3 :-p. How have I managed to
prepare this series with one patch from the middle missing?!?! The
cover letter seems to be correct.

I'll resend the patches 8-12/12.


Thanks,

--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/