Re: [PATCH v2 1/2] x86: introduce kaslr_offset()

[Jiri Kosina]

On Tue, 28 Apr 2015, Borislav Petkov wrote:

> > > Offset that has been chosen for kaslr during kernel decompression can be 
> > > easily computed as a difference between _text and __START_KERNEL. We are 
> > > already making use of this in dump_kernel_offset() notifier and in 
> > > arch_crash_save_vmcoreinfo().
> > > 
> > > Introduce kaslr_offset() that makes this computation instead of 
> > > hard-coding it, so that other kernel code (such as live patching) can make 
> > > use of it. Also convert existing users to make use of it.
> > > 
> > > Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
> > > ---
> > > 
> > > It'd be great to potentially have Ack from x86 guys for this patch so that 
> > > I could take it through livepatching.git with the depending 2/2 patch. 
> > > Thanks.
> > > 
> > > v1 -> v2: convert arch_crash_save_vmcoreinfo(), as spotted by Josh 
> > > 	  Poimboeuf.
> > 
> > FWIW this patch is equivalent transofrmation without any effects on the 
> > resulting code:
> > 
> > 	$ diff -u vmlinux.old.asm vmlinux.new.asm
> > 	--- vmlinux.old.asm     2015-04-28 17:55:19.520983368 +0200
> > 	+++ vmlinux.new.asm     2015-04-28 17:55:24.141206072 +0200
> > 	@@ -1,5 +1,5 @@
> > 	 
> > 	-vmlinux.old:     file format elf64-x86-64
> > 	+vmlinux.new:     file format elf64-x86-64
> > 	 
> > 	 
> > 	 Disassembly of section .text:
> > 	$
> 
> Then those are easy. Please add that piece of infomation to the commit
> message.
> 
> With that:
> 
> Acked-by: Borislav Petkov <bp@xxxxxxx>

Applied to livepatching.git#for-4.2/kaslr. Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/