Re: [RFCv3 PATCH 29/48] sched: Highest energy aware balancing sched_domain level pointer

[Dietmar Eggemann]

On 28/04/15 10:09, pang.xunlei@xxxxxxxxxx wrote:
> Morten Rasmussen <morten.rasmussen@xxxxxxx>  wrote 2015-02-05 AM 02:31:06:
> 
>> Morten Rasmussen <morten.rasmussen@xxxxxxx>
>> [RFCv3 PATCH 29/48] sched: Highest energy aware balancing
>> sched_domain level pointer
>>
>> Add another member to the family of per-cpu sched_domain shortcut
>> pointers. This one, sd_ea, points to the highest level at which energy
>> model is provided. At this level and all levels below all sched_groups
>> have energy model data attached.

[...]

>> @@ -5766,6 +5767,14 @@ static void update_top_cache_domain(int cpu)
>>  
>>     sd = highest_flag_domain(cpu, SD_ASYM_PACKING);
>>     rcu_assign_pointer(per_cpu(sd_asym, cpu), sd);
>> +
>> +   for_each_domain(cpu, sd) {
>> +      if (sd->groups->sge)
> 
> sge is like sgc, I think the test will always return true, no?

True for the current implementation. This code will make more sense once
we integrate the changes you proposed for '[RFCv3 PATCH 23/48] sched:
Allocate and initialize energy data structures' into the next version.

[...]

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/